Update EventEmitter.h#1
Open
igormarkoff wants to merge 1 commit intomasterfrom
Open
Conversation
Using from different projects in the same xcode workspace causes typeid returns different type_info for the same type (text name of the type is the same but its type_index is different). Since name is the same, using std::string as key of listeners map fixes the issue. One more change - I'm not sure whether this is a typo or not, but you use type (not Type) on line 52, I fixed this as well. If this is incorrect please revert.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using from different projects in the same xcode workspace causes typeid returns different type_info for the same type (text name of the type is the same but its type_index is different). Since name is the same, using std::string as key of listeners map fixes the issue.
One more change - I'm not sure whether this is a typo or not, but you use type (not Type) on line 52, I fixed this as well. If this is incorrect please revert.